refactor(ng-dev): Add github api retries for increased reliability#3582
refactor(ng-dev): Add github api retries for increased reliability#3582josephperrott merged 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a retry mechanism for GitHub API calls by implementing a helper function and a proxy-based wrapper for Octokit properties. The feedback identifies several critical improvements for the retry logic: the proxy needs to be recursive to handle nested namespaces like 'rest' and requires an 'apply' trap for direct function calls. Additionally, the GraphQL retry logic should be refined to avoid retrying permanent failures, and the 'paginate' method should be included in the retry system.
thePunderWoman
force-pushed
the
github-reliability
branch
from
5e95d1e to
3fbd2d0
Compare
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
I would love to see the comment about not applying retry recursively to be addressed as well
Github has been increasingly flakey lately resulting in partial merges and all sorts of issues with failures in the tooling. This adds a retry system to ensure github API calls retry up to 3 times if they fail.
thePunderWoman
force-pushed
the
github-reliability
branch
from
3fbd2d0 to
a182191
Compare
|
@josephperrott It has now been addressed. We should be good to go here. :) |
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
Github has been increasingly flakey lately resulting in partial merges and all sorts of issues with failures in the tooling. This adds a retry system to ensure github API calls retry up to 3 times if they fail.